commit 49c000a0f5630c20b478afc551555d5811be86cb
from: Sergey Bronnikov <estetus@gmail.com>
date: Wed Aug 07 10:47:51 2024 UTC

rules/python: fix and rename pass_body rule

commit - f1104eeff2eea43bc0b93e77c31b55d60ca57688
commit + 49c000a0f5630c20b478afc551555d5811be86cb
blob - 149b2bbf7fd7f63d9af82b81c323f9012b752260 (mode 644)
blob + /dev/null
--- rules/python/pass-body.py
+++ /dev/null
@@ -1,27 +0,0 @@
-# ruleid:pass-body-range
-for i in range(100):
-    pass
-
-# ruleid:pass-body-fn
-def foo():
-    pass
-
-def __init__(self):
-    # ok
-    pass
-
-def __init__(self, other):
-    # ok
-    pass
-
-class foo:
-    def somemethod():
-        # ok
-        pass
-
-
-class foobar:
-    def someothermethod():
-        # ruleid:pass-body-range
-        for i in range(100):
-            pass
blob - /dev/null
blob + 3bc92dde5a9d2e8eab22aa908028c72e24ecbdbf (mode 644)
--- /dev/null
+++ rules/python/pass_body.py
@@ -0,0 +1,19 @@
+# ruleid: pass_body
+for i in range(100):
+    pass
+
+def foo_function():
+    # ruleid: pass_body
+    pass
+
+class foo_class:
+    def somemethod():
+        # ruleid: pass_body
+        pass
+
+
+class bar_class:
+    def someothermethod():
+        # ruleid: pass_body
+        for i in range(100):
+            pass
blob - 0afd9a1a397c3bf0386dc667c4ad39e71e724255 (mode 644)
blob + /dev/null
--- rules/python/pass-body.yaml
+++ /dev/null
@@ -1,23 +0,0 @@
-rules:
-- id: pass-body-fn
-  patterns:
-  - pattern-not-inside: |
-      def __init__(self, ...):
-          ...
-  - pattern-not-inside: |
-      class $A:
-           ...
-  - pattern: |
-      def $X(...):
-          pass
-  message: '`pass` is the body of function $X. Consider removing this or raise NotImplementedError() if this is a TODO'
-  languages: [python]
-  severity: WARNING
-
-- id: pass-body-range
-  pattern: |
-    for $X in $Y:
-        pass
-  message: '`pass` is the body of for $X in $Y. Consider removing this or raise NotImplementedError() if this is a TODO'
-  languages: [python]
-  severity: WARNING
blob - /dev/null
blob + e519ec24c4bf1f18a9ef0418b45e36ce2282ea27 (mode 644)
--- /dev/null
+++ rules/python/pass_body.yaml
@@ -0,0 +1,17 @@
+rules:
+  - id: pass_body
+    pattern-either:
+      - pattern: |
+          class $CLASS:
+            pass
+      - pattern: |
+          def $FUNC(...):
+            pass
+      - pattern: |
+          for $X in $Y:
+            pass
+    message: |
+        "pass" the body of function $X. Consider removing this or raise
+        "NotImplementedError()" if this is a TODO.
+    languages: [python]
+    severity: WARNING