commit 9267a13adf66323ac2ffb0544b81f40f0f74dce5
from: Sergey Bronnikov <estetus@gmail.com>
date: Wed Aug 07 10:47:51 2024 UTC

rules/python: fix random_wo_seed_on_current_time rule

commit - 73014509f73228fdc6dac21e5c61f8ba22dc3bad
commit + 9267a13adf66323ac2ffb0544b81f40f0f74dce5
blob - 1a67b5d6116e3fa45edc6b3f70e04e70dd0abe12 (mode 644)
blob + /dev/null
--- rules/python/flakiness/random_seed_depends-on_current_time.py
+++ /dev/null
@@ -1,9 +0,0 @@
-import random
-import time
-from datetime import datetime
-
-# rule-id: random_seed_depends_on_current_time
-random.seed(datetime.now())
-
-# rule-id: random_seed_depends_on_current_time
-random.seed(time.now())
blob - /dev/null
blob + b514b7ac6fdf16059e963547b630b004b2651ffb (mode 644)
--- /dev/null
+++ rules/python/flakiness/random_seed_depends_on_current_time.py
@@ -0,0 +1,5 @@
+import random
+import time
+
+# rule-id: random_seed_depends_on_current_time
+random.seed(time.time())
blob - 91c2d2fa9853d530dce8bce7505bb45d634bb4f6 (mode 644)
blob + /dev/null
--- rules/python/flakiness/random_seed_depends-on_current_time.yaml
+++ /dev/null
@@ -1,13 +0,0 @@
-rules:
-- id: random_seed_depends_on_current_time
-  patterns:
-    - pattern-either: 
-      - pattern: |
-          random.seed(..., time.now(), ...)
-      - pattern: |
-          random.seed(..., datetime.now(), ...)
-  message: |
-    random seed depends on non-constant value
-  languages:
-  - python
-  severity: WARNING
blob - /dev/null
blob + f422af7a8740144bb7e12fb4da369c75a4d4ed8c (mode 644)
--- /dev/null
+++ rules/python/flakiness/random_seed_depends_on_current_time.yaml
@@ -0,0 +1,14 @@
+rules:
+  - id: random_seed_depends_on_current_time
+    patterns:
+      - pattern: random.seed($T)
+      - pattern-either:
+          - pattern: $T = datetime.now()
+          - pattern: $T = time.time()
+          - pattern: $T = time.clock()
+          - pattern: $T = timeit.timeit()
+    message: |
+        Random seed depends on non-constant value.
+    languages:
+      - python
+    severity: WARNING