commit d835c495c1a58d6f02f2a6abe81512e704023648 from: Ilya Verbin via: Vladimir Davydov date: Mon Oct 14 14:28:29 2024 UTC box: fix UBSan error regarding misaligned store in field_map.c The type cast is unnecessary and causes false-positive errors: NO_WRAP ``` ./src/box/field_map.c:110:10: runtime error: store to misaligned address 0x507000071082 for type 'uint32_t *' (aka 'unsigned int *'), which requires 4 byte alignment 0x507000071082: note: pointer points here 01 00 00 00 be be be be f0 ff ff ff 02 00 00 00 be be be be be be be be 00 00 00 00 00 00 00 00 ^ SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ./src/box/field_map.c:110:10 ``` NO_WRAP Closes #10631 NO_DOC=bugfix NO_CHANGELOG=minor NO_TEST=tested by debug_asan_clang workflow (cherry picked from commit 5ddbd85cc377a29dc27d01ad06acdc6acc24cc5b) commit - ada3dddf380fd4a80441d9b61f2743133d9a53c8 commit + d835c495c1a58d6f02f2a6abe81512e704023648 blob - dc903115e07da6379e6d925a080fe6fdcaefb78d blob + 7fb4c307f783d4fd16bbd00b409d3fb5a415fda2 --- src/box/field_map.c +++ src/box/field_map.c @@ -116,10 +116,10 @@ field_map_build(struct field_map_builder *builder, cha /** Retrive memory for the extent. */ store_u32(&field_map[i], extent_wptr - (char *)field_map); store_u32(extent_wptr, extent->size); + extent_wptr += sizeof(uint32_t); uint32_t extent_offset_sz = extent->size * sizeof(uint32_t); - memcpy(&((uint32_t *) extent_wptr)[1], extent->offset, - extent_offset_sz); - extent_wptr += sizeof(uint32_t) + extent_offset_sz; + memcpy(extent_wptr, extent->offset, extent_offset_sz); + extent_wptr += extent_offset_sz; } assert(extent_wptr == buffer + builder->extents_size); }