Commit Diff

Commit:
89424284376966e184041c846c52ff69dc554b14
From:
Magomed Kostoev <m.kostoev@tarantool.org>
Via:
Serge Petrenko <35663196+sergepetrenko@users.noreply.github.com>
Date:
Message:
memtx: split the `memtx_tx_tuple_clarify_impl` function Prior to this patch the `memtx_tx_tuple_clarify_impl` function been used in order to clarify a tuple from index. Similar functionality regarding to top tuple stories will be required when count gaps will be implemented, so let's split the function into two: `memtx_tx_tuple_clarify_impl` and `memtx_tx_story_clarify_impl`, and make the first one call the latter. Needed for #8204 NO_DOC=refactoring NO_TEST=refactoring NO_CHANGELOG=refactoring
Actions:
Patch | Tree
commit - 7bcbdc9745624c3a47098bc63402558e1fb169ed
commit + 89424284376966e184041c846c52ff69dc554b14
blob - 5f8f5e079cd7cb7e53e95316ccc3dd12f47b925b
blob + 349ae8b65acfa73f96c5232af0a83a9531c99e39
--- src/box/memtx_tx.c
+++ src/box/memtx_tx.c
@@ -2759,12 +2759,10 @@ memtx_tx_history_commit_stmt(struct txn_stmt *stmt)
  * Do actual work.
  */
 static struct tuple *
-memtx_tx_tuple_clarify_impl(struct txn *txn, struct space *space,
-			    struct tuple *tuple, struct index *index,
+memtx_tx_story_clarify_impl(struct txn *txn, struct space *space,
+			    struct memtx_story *top_story, struct index *index,
 			    uint32_t mk_index, bool is_prepared_ok)
 {
-	assert(tuple_has_flag(tuple, TUPLE_IS_DIRTY));
-	struct memtx_story *top_story = memtx_tx_story_get(tuple);
 	struct memtx_story *story = top_story;
 	bool own_change = false;
 	struct tuple *result = NULL;
@@ -2830,6 +2828,21 @@ memtx_tx_tuple_clarify_impl(struct txn *txn, struct sp
 
 /**
  * Helper of @sa memtx_tx_tuple_clarify.
+ * Do actual work.
+ */
+static struct tuple *
+memtx_tx_tuple_clarify_impl(struct txn *txn, struct space *space,
+			    struct tuple *tuple, struct index *index,
+			    uint32_t mk_index, bool is_prepared_ok)
+{
+	assert(tuple_has_flag(tuple, TUPLE_IS_DIRTY));
+	struct memtx_story *story = memtx_tx_story_get(tuple);
+	return memtx_tx_story_clarify_impl(txn, space, story, index,
+					   mk_index, is_prepared_ok);
+}
+
+/**
+ * Helper of @sa memtx_tx_tuple_clarify.
  * Detect whether the transaction can see prepared, but unconfirmed commits.
  */
 static bool