Commit Diff

Commit:
99276cabb31a4645caa125813d725ac1e0944119
From:
Sergey Bronnikov <estetus@gmail.com>
Via:
Sergey Bronnikov <sergeyb@tarantool.org>
Date:
Message:
shellcheck Fixes # Closes # Needed for # See also # NO_CHANGELOG=internal NO_DOC=internal NO_TEST=internal
Actions:
Patch | Tree
commit - 6bb89aa0630313bedca5eb67c11131e8aa2b5b82
commit + 99276cabb31a4645caa125813d725ac1e0944119
blob - ed6db1daa74f3f5d658c557731a26541083e141f
blob + 22fc079af4ac4c2157db8e1a287c359f87a64168
--- .github/actions/install-deps-debian/action.yml
+++ .github/actions/install-deps-debian/action.yml
@@ -21,7 +21,8 @@ runs:
           automake \
           libtool \
           util-linux \
-          shellcheck
+          shellcheck \
+          jq
 
         luarocks install luacheck 0.26.1
         gem install coveralls-lcov
blob - 724354588bff6fc90d6f431194fd458acc296eb0
blob + 3b41473eaeb0e4d002fc75fc6b10674d9e339547
--- .github/workflows/lint.yml
+++ .github/workflows/lint.yml
@@ -142,6 +142,8 @@ jobs:
       image: docker.io/tarantool/testing:ubuntu-focal
 
     steps:
+      - name: Install deps
+        uses: ./.github/actions/install-deps-debian
       - name: Prepare checkout
         uses: tarantool/actions/prepare-checkout@master
       - uses: actions/checkout@v4
@@ -149,16 +151,23 @@ jobs:
           fetch-depth: 0
           submodules: recursive
       - name: Run ShellCheck
-        uses: ludeeus/action-shellcheck@master
+        uses: reviewdog/action-shellcheck@v1
         with:
-          ignore_paths: >-
-            third_party/*
-            test-run/*
-            static-build/make_packages.sh
-            tools/check-downgrade-versions.sh
-            tools/check-entrypoint-tag.sh
-            tools/check_push_master.sh
-            tools/run-jepsen-tests.sh
+          github_token: ${{ secrets.github_token }}
+          reporter: github-pr-review
+          check_all_files_with_shebangs: "false"
+          pattern: |
+            *.bash
+            *.sh
+          exclude: |
+            */.git/*
+            ./third_party/*
+            ./test-run/*
+            ./static-build/make_packages.sh
+            ./tools/check-downgrade-versions.sh
+            ./tools/check-entrypoint-tag.sh
+            ./tools/check_push_master.sh
+            ./tools/run-jepsen-tests.sh
       - name: Send VK Teams message on failure
         if: failure()
         uses: ./.github/actions/report-job-status