Commit Diff

Commit:
b7b095a1563f47105aa86b80b1fd8f8fe5df9915
From:
Sergey Bronnikov <sergeyb@tarantool.org>
Date:
Message:
httpc: replace ibuf_alloc with xibuf_alloc There is no check for NULL for a value returned by `ibuf_alloc`, the NULL will be passed to `memcpy()` if the aforementioned function will return a NULL. The patch fixes that by replacing `ibuf_alloc` with macros `xibuf_alloc` that never return NULL. Found by Svace. NO_CHANGELOG=codehealth NO_DOC=codehealth NO_TEST=codehealth
Actions:
Patch | Tree
commit - 4a866f64d64c610a3c8441835fee3d8dda5eca71
commit + b7b095a1563f47105aa86b80b1fd8f8fe5df9915
blob - 465b8114bf9f5abffed10760ae52cdab506c5a4e
blob + a7abadf7b349ab1a459672df5cba69dea521e0b2
--- src/httpc.c
+++ src/httpc.c
@@ -601,7 +601,7 @@ httpc_request_io_read(struct httpc_request *req, char 
 
 		if (recv_len > remain) {
 			const size_t tocopy = recv_len - remain;
-			char *ptr = ibuf_alloc(&req->io_recv, tocopy);
+			char *ptr = xibuf_alloc(&req->io_recv, tocopy);
 			memcpy(ptr, recv + remain, tocopy);
 		}
 
@@ -649,7 +649,7 @@ httpc_request_io_write(struct httpc_request *req, cons
 
 	if (len > 0) {
 		ibuf_reset(&req->send);
-		char *buf = ibuf_alloc(&req->send, len);
+		char *buf = xibuf_alloc(&req->send, len);
 		memcpy(buf, ptr, len);
 	} else {
 		req->io_send_closed = true;