Commit Diff

Commit:
e92f78068eecc73d20ca936c07d710fa462434af
From:
Andrey Saranchin <Andrey22102001@gmail.com>
Via:
Vladimir Davydov <vdavydov@tarantool.org>
Date:
Message:
memtx: do not pass NULL to memcpy when creating gap item in MVCC According to the C standard, passing `NULL` to `memcpy` is UB, even if it copies nothing (number of bytes to copy is 0). The commit fixes such situation in memtx MVCC. Closes tarantool/security#129 NO_TEST=fix UB NO_CHANGELOG=fix UB NO_DOC=fix UB (cherry picked from commit 24d38cef5adff900bea2484235762678ac1c5234)
Actions:
Patch | Tree
commit - a800ccc68bab2a31c927e7393e07ade881602acb
commit + e92f78068eecc73d20ca936c07d710fa462434af
blob - 7810d5f7b84ba4c99c469c8acb14918c822dc5f0
blob + 6e3f8bd0e15319656319e94c45737b682bb82289
--- src/box/memtx_tx.c
+++ src/box/memtx_tx.c
@@ -3124,7 +3124,8 @@ memtx_tx_nearby_gap_item_new(struct txn *txn, enum ite
 		item->key = memtx_tx_xregion_alloc(txn, item->key_len,
 						   MEMTX_TX_ALLOC_TRACKER);
 	}
-	memcpy((char *)item->key, key, item->key_len);
+	if (item->key != NULL)
+		memcpy((char *)item->key, key, item->key_len);
 	return item;
 }